Repository navigation
Deprecate unread factory config blocks, delete loadSourceForBridge (#59439) - #59439
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127294779. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
…eact#59439) Summary: Pull Request resolved: react#59439 Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (`loadSourceForBridge`), which has no writers at all. Also remove our own dead write and the only reader method. Changelog: [Internal] Differential Revision: D127294779
christophpurrer
force-pushed
the
export-D127294779
branch
from
October 24, 2026 03:24
97eb18d to
5892ad4
Compare
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…eact#59439) Summary: Pull Request resolved: react#59439 Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (`loadSourceForBridge`), which has no writers at all. Also remove our own dead write and the only reader method. Changelog: [Internal] Differential Revision: D127294779
christophpurrer
force-pushed
the
export-D127294779
branch
2 times, most recently
from
October 27, 2026 14:37
af8d48b to
c97e15d
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…eact#59439) Summary: Pull Request resolved: react#59439 Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (`loadSourceForBridge`), which has no writers at all. Also remove our own dead write and the only reader method. Changelog: [Internal] Differential Revision: D127294779
Visual regressionNo visual differences at |
christophpurrer
force-pushed
the
export-D127294779
branch
from
October 27, 2026 22:19
c97e15d to
5307163
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…eact#59439) Summary: Pull Request resolved: react#59439 Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (`loadSourceForBridge`), which has no writers at all. Also remove our own dead write and the only reader method. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294779
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…eact#59439) Summary: Pull Request resolved: react#59439 Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (`loadSourceForBridge`), which has no writers at all. Also remove our own dead write and the only reader method. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294779
christophpurrer
force-pushed
the
export-D127294779
branch
from
October 27, 2026 23:07
5307163 to
cb71071
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…eact#59439) Summary: Pull Request resolved: react#59439 Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (`loadSourceForBridge`), which has no writers at all. Also remove our own dead write and the only reader method. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294779
christophpurrer
force-pushed
the
export-D127294779
branch
2 times, most recently
from
October 28, 2026 15:20
1df887a to
5229b88
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…eact#59439) Summary: Pull Request resolved: react#59439 Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (`loadSourceForBridge`), which has no writers at all. Also remove our own dead write and the only reader method. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294779
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…eact#59439) Summary: Pull Request resolved: react#59439 Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (`loadSourceForBridge`), which has no writers at all. Also remove our own dead write and the only reader method. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294779
christophpurrer
force-pushed
the
export-D127294779
branch
from
October 28, 2026 15:50
5229b88 to
bc9fa22
Compare
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D127294779
branch
from
October 29, 2026 21:54
bc9fa22 to
4d9779c
Compare
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 30, 2026
…eact#59439) Summary: Pull Request resolved: react#59439 Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (`loadSourceForBridge`), which has no writers at all. Also remove our own dead write and the only reader method. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294779
christophpurrer
force-pushed
the
export-D127294779
branch
from
October 30, 2026 04:32
4d9779c to
ea95e30
Compare
andrewdacenko
approved these changes
Oct 30, 2026
…eact#59439) Summary: Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (`loadSourceForBridge`), which has no writers at all. Also remove our own dead write and the only reader method. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D127294779
christophpurrer
force-pushed
the
export-D127294779
branch
from
October 30, 2026 19:25
ea95e30 to
1d3c79e
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in 7839a58 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Seven bridge-related factory configuration blocks are written but never read. Mark them deprecated since external clients still set them, and delete the eighth (
loadSourceForBridge), which has no writers at all. Also remove our own dead write and the only reader method.Changelog: [Internal]
Reviewed By: andrewdacenko
Differential Revision: D127294779